Introduce resolver module to the CoreDNS plugin #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextSmoothWeightedItem should increment 'total' after possibly updating 'item.effectiveWeight' otherwise 'best.currentWeight' may not reflect the correct value thereby resulting in the same item returned in consecutive invocations. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
aswinsuryan,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1105/tpantelis/add_resolver |
aswinsuryan
approved these changes
Feb 23, 2023
Currently, ServiceImport and EndpointSlice processing are in separate components, with ServiceImports used for resolving non-headless service queries and EndpointSlice used for headless services. However, the upcoming ServiceImport aggregation changes will require direct coordination between ServiceImports and EndpointSlices for resolving DNS records. Thus, it makes sense to combine the processing in 'serviceimport.Map' and 'endpointslice.Map ' into a single component. A new 'resolver' module is introduced to contain a controller component that watches for ServiceImports and EndpointSlices and feeds them into a resolver component that builds internal structs used to provide DNSRecords on request. Subsequent commits will modify the plugin handler to user the resolver. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
add_resolver
branch
from
cc2487a
to
b42fda2
Compare
|
🤖 Closed branches: [z_pr1105/tpantelis/add_resolver] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ServiceImportandEndpointSliceprocessing are in separate components, withServiceImports used for resolving non-headless service queries andEndpointSliceused for headless services. However, the upcomingServiceImportaggregation changes will require direct coordination betweenServiceImports andEndpointSlices for resolving DNS records. Thus, it makes sense to combine the processing in serviceimport.Map and endpointslice.Map into a single component. A new resolver module is introduced to contain a controller component that watches forServiceImports andEndpointSlices and feeds them into a resolver component that builds internal structs used to provideDNSRecords on request.Subsequent commits will modify the plugin handler to user the resolver.
Related to #214